Browse Source

Code should not be duplicated

1.0
Andrés Montañez 10 years ago
parent
commit
5d39e46d9e
  1. 2
      Mage/Task/BuiltIn/Deployment/ReleaseTask.php
  2. 35
      Mage/Task/BuiltIn/Deployment/Strategy/GitRemoteCacheTask.php

2
Mage/Task/BuiltIn/Deployment/ReleaseTask.php

@ -133,7 +133,7 @@ class ReleaseTask extends AbstractTask implements IsReleaseAware, SkipOnOverride
$directoryToDelete = $releasesDirectory . '/' . $releaseIdToDelete; $directoryToDelete = $releasesDirectory . '/' . $releaseIdToDelete;
if ($directoryToDelete != '/') { if ($directoryToDelete != '/') {
$command = 'rm -rf ' . $directoryToDelete; $command = 'rm -rf ' . $directoryToDelete;
$this->runCommandRemote($command); $result = $result && $this->runCommandRemote($command);
} }
} }
} }

35
Mage/Task/BuiltIn/Deployment/Strategy/GitRemoteCacheTask.php

@ -97,39 +97,8 @@ class GitRemoteCacheTask extends AbstractTask implements IsReleaseAware
$command = 'cd ' . $remoteCacheFolder . ' && /usr/bin/env git archive ' . $branch . ' | tar -x -C ' . $deployToDirectory . ' ' . $excludeCmd; $command = 'cd ' . $remoteCacheFolder . ' && /usr/bin/env git archive ' . $branch . ' | tar -x -C ' . $deployToDirectory . ' ' . $excludeCmd;
$result = $this->runCommandRemote($command) && $result; $result = $this->runCommandRemote($command) && $result;
// Count Releases if ($result) {
if ($this->getConfig()->release('enabled', false) == true) { $this->cleanUpReleases();
$releasesDirectory = $this->getConfig()->release('directory', 'releases');
$symlink = $this->getConfig()->release('symlink', 'current');
if (substr($symlink, 0, 1) == '/') {
$releasesDirectory = rtrim($this->getConfig()->deployment('to'), '/') . '/' . $releasesDirectory;
}
$maxReleases = $this->getConfig()->release('max', false);
if (($maxReleases !== false) && ($maxReleases > 0)) {
$releasesList = '';
$countReleasesFetch = $this->runCommandRemote('ls -1 ' . $releasesDirectory, $releasesList);
$releasesList = trim($releasesList);
if ($countReleasesFetch && $releasesList != '') {
$releasesList = explode(PHP_EOL, $releasesList);
if (count($releasesList) > $maxReleases) {
$releasesToDelete = array_diff($releasesList, array($this->getConfig()->getReleaseId()));
sort($releasesToDelete);
$releasesToDeleteCount = count($releasesToDelete) - $maxReleases;
$releasesToDelete = array_slice($releasesToDelete, 0, $releasesToDeleteCount + 1);
foreach ($releasesToDelete as $releaseIdToDelete) {
$directoryToDelete = $releasesDirectory . '/' . $releaseIdToDelete;
if ($directoryToDelete != '/') {
$command = 'rm -rf ' . $directoryToDelete;
$result = $result && $this->runCommandRemote($command);
}
}
}
}
}
} }
return $result; return $result;

Loading…
Cancel
Save