From 8ae83cbabd8622c6c4d40c4c5092d32ebf848ec8 Mon Sep 17 00:00:00 2001 From: Ismael Ambrosi Date: Fri, 5 Dec 2014 02:40:30 -0200 Subject: [PATCH] Use instanceof instead of method is_a Since is_a is a method, it is significantly slower than using instanceof Following is a perfomance comparison: http://micro-optimization.com/is_a-vs-instanceof --- Mage/Task/Factory.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Mage/Task/Factory.php b/Mage/Task/Factory.php index 912026f..57dff35 100644 --- a/Mage/Task/Factory.php +++ b/Mage/Task/Factory.php @@ -59,7 +59,7 @@ class Factory $instance = new $className($taskConfig, $inRollback, $stage, $taskParameters); - if (!is_a($instance, 'Mage\Task\AbstractTask')) { + if (!($instance instanceof AbstractTask)) { throw new Exception('The Task ' . $taskName . ' must be an instance of Mage\Task\AbstractTask.'); }