hauke/Magallanes
1
0
Fork 0
mirror of https://github.com/hauke68/Magallanes.git synced 2025-11-04 00:50:18 +01:00
Code Issues Releases Wiki Activity

Use instanceof instead of method is_a

Browse Source 
Since is_a is a method, it is significantly slower than using instanceof

Following is a perfomance comparison:
http://micro-optimization.com/is_a-vs-instanceof
This commit is contained in:
Ismael Ambrosi 2014-12-05 02:40:30 -02:00
parent 5199a915b6
commit 8ae83cbabd
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Mage/Task/Factory.php
View File

@ -59,7 +59,7 @@ class Factory
$instance = new $className($taskConfig, $inRollback, $stage, $taskParameters); $instance = new $className($taskConfig, $inRollback, $stage, $taskParameters);
if (!is_a($instance, 'Mage\Task\AbstractTask')) { if (!($instance instanceof AbstractTask)) {
throw new Exception('The Task ' . $taskName . ' must be an instance of Mage\Task\AbstractTask.'); throw new Exception('The Task ' . $taskName . ' must be an instance of Mage\Task\AbstractTask.');
} }